Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo-deny failing on webc crate #3427

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Fix cargo-deny failing on webc crate #3427

merged 3 commits into from
Dec 16, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Dec 15, 2022

No description provided.

@theduke
Copy link
Contributor

theduke commented Dec 15, 2022

I guess it fails because of the unmaintained warnings?

Guess we'll need to whitelist those as well.

theduke
theduke approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after the mentioned comments are added.

deny.toml Outdated Show resolved Hide resolved
@ptitSeb
Copy link
Contributor

ptitSeb commented Dec 16, 2022

bors r+

@theduke
Copy link
Contributor

theduke commented Dec 16, 2022

@fschutt I actually meant comments for all the crates, not just webc, because we will have no idea why they are whitelisted in a months time.

But we can just include that in the #3426 PR.

@bors
Copy link
Contributor

bors bot commented Dec 16, 2022

Build succeeded:

  • Code lint

@bors bors bot merged commit 4720045 into master Dec 16, 2022
@bors bors bot deleted the fix-cargo-deny branch December 16, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb left review comments

@theduke theduke theduke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fschutt @theduke @ptitSeb